feat: implement enhanced transaction history retrieval#7689
Conversation
…aMask/core into enhanced_transaction_history
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| readonly #updateTransactions?: boolean; | ||
|
|
||
| readonly #isEnhancedHistoryEnabled: boolean; |
There was a problem hiding this comment.
Minor, alphabetical properties.
There was a problem hiding this comment.
Variable name is changed now.
| let connectionStateChangedHandler: (info: WebSocketConnectionInfo) => void; | ||
| let selectedAccountChangedHandler: () => void; | ||
|
|
||
| beforeEach(() => { |
There was a problem hiding this comment.
Minor, we usually avoid nested beforeEach and variables in describe to help readability and reuse.
There was a problem hiding this comment.
I made the beforeEach small but these test cases need different mocking for feature flag thus this nested beforeEach is needed.
| */ | ||
| export enum FeatureFlag { | ||
| EIP7702 = 'confirmations_eip_7702', | ||
| EnhancedHistoryRetrieval = 'enhanced_history_retrieval', |
There was a problem hiding this comment.
Since this is a stand alone boolean, can we instead re-use confirmations_incoming_transactions?
And could we be more specific with the property name, such as useWebsockets?
There was a problem hiding this comment.
Good point, I updated the PR
…aMask/core into enhanced_transaction_history
packages/transaction-controller/src/helpers/IncomingTransactionHelper.ts
Show resolved
Hide resolved
2 participants
Explanation
This PR implements enhanced transaction history retrieval for the IncomingTransactionHelper. When the enhanced_history_retrieval feature flag is enabled and WebSocket is connected, incoming transactions are fetched via event-driven updates instead of polling, reducing unnecessary API calls and improving responsiveness.
References
Ref: https://github.com/MetaMask/MetaMask-planning/issues/6682
Checklist
Note
Introduces enhanced, event-driven incoming transaction history retrieval.
IncomingTransactionHelpersubscribes toBackendWebSocketService:connectionStateChanged,AccountActivityService:transactionUpdated, andAccountsController:selectedAccountChange; polling is skipped when enabledisIncomingTransactionsUseWebsocketsEnabledfeature flag and tests; retains legacy polling when disabledAllowedEventsinTransactionControllerand adds@metamask/core-backenddependency plus TS project referencesWritten by Cursor Bugbot for commit 8453f3b. This will update automatically on new commits. Configure here.